-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string does not match ~[]E
error
#5675
Fix string does not match ~[]E
error
#5675
Conversation
What is this exactly? I do not get this error, nor does our CI, and builds succeeded. |
Yea, I was kind of surprised myself too. I hit this error when building Caddy with one of my modules. Another person seems to have hit the same issue with a custom module: #5673 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Alrighty then.
LGTM. I'm not sure why we need the exp package here anyway. Thanks
Does the import need updating? (Run gofmt) Oh nvm we still use Compact |
Doesn't look like it. Still one |
Weird that only this occurrence needs changing then. As I do not get this error, nor does our CI, I'm trusting you on this 😊 |
Here's a reproducer on the playground: https://go.dev/play/p/NsaynrOjz9i |
Is that using the same commit of x/exp that is in our go.mod? (Sorry, I would check myself, but I'm traveling/mobile and scrambling to get my laptop set up to tag a signed release.) |
Oh, I guess it needs to be |
That does compile on the playground 🙂 |
If the playground always uses the latest commits, ours is not using the latest commit of x/exp. That might be the difference, somehow? |
Maybe this commit is related: golang/go@0a48e5c |
Fixes #5674